[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

lebedev.ri added a comment. @JonasToth @erichkeane thank you for taking care of this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

This revision was automatically updated to reflect the committed changes. Closed by commit rL352231: [clang-tidy] fix unit tests for dropped _Float16 support in X86 (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183580. JonasToth marked an inline comment as done. JonasToth added a comment. - last nit, remove the disabled in hexadecimal Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183579. JonasToth added a comment. - Revert "add REQUIRES: for the readability unit-tests where necessary" as its not necessary because only the frontend is run Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth updated this revision to Diff 183578. JonasToth added a comment. - add REQUIRES: for the readability unit-tests where necessary Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249 Files: test/clang-

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

lebedev.ri added inline comments. Comment at: test/clang-tidy/readability-uppercase-literal-suffix-float16.cpp:2 +// RUN: %check_clang_tidy %s readability-uppercase-literal-suffix %t -- -- -target aarch64-linux-gnu -I %S + +#include "readability-uppercase-literal-suffix.h" -

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57249/new/ https://reviews.llvm.org/D57249

[PATCH] D57249: [clang-tidy] fix unit tests for dropped _Float16 support in X86

JonasToth created this revision. JonasToth added reviewers: aaron.ballman, erichkeane, lebedev.ri. Herald added subscribers: cfe-commits, kristof.beyls, xazax.hun, javed.absar. Because _Float16 was disabled for X86 targets the unit-tests started failing. Extract the pieces for _Float16 and run the