[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

This revision was automatically updated to reflect the committed changes. Closed by commit rL352275: [AST][NFC] Various cleanups to GenericSelectionExpr (authored by brunoricci, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57238?vs=

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

aaron.ballman added inline comments. Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); riccibruno wrote: > aaron.ballman wrote: > > If you wanted to fix up `i` to be `Idx` or somet

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

riccibruno marked an inline comment as done. riccibruno added inline comments. Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); aaron.ballman wrote: > If you wanted to fix up `i`

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: include/clang/AST/Expr.h:5095 + + Expr *getAssocExpr(unsigned i) { +return cast(SubExprs[AssocExprStartIndex + i]); If y

[PATCH] D57238: [AST][NFC] Various cleanups to GenericSelectionExpr

riccibruno created this revision. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Various cleanups to GenericSelectionExpr, factored out of D57104 . In particular: 1. Move the friend declaration to the top. 2. Introduce a constant `Resu