[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL354027: [ASTImporter] Check visibility/linkage of functions and variables (authored by martong, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. @shafik Thanks for the review! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 186802. martong added a comment. Rebase to master(trunk) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/AST/ASTImporter.h lib/AST/ASTImporter.cpp unittests

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. Herald added a subscriber: jdoerfert. I ran `check-lldb` locally and it looks good. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.ll

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong added a comment. Ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 184697. martong added a comment. Herald added a project: clang. - Move hunks into this patch from parent patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/A

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183834. martong added a comment. I have created a separate patch for the test related refactor, this patch now depends on that patch and contains merely the visibility related change and their tests. Repository: rC Clang CHANGES SINCE LAST ACTION https:

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong marked an inline comment as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2954 +return Found->hasExternalFormalLinkage(); + else if (Importer.GetFromTU(Found) == From->getTranslationUnitDecl()) { +if (From->isInAnonymousNamespace()) ---

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183826. martong marked 5 inline comments as done. martong added a comment. - Remove dumpDeclContext() call - Remove superfluous else Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Fi

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

shafik added inline comments. Comment at: lib/AST/ASTImporter.cpp:2954 +return Found->hasExternalFormalLinkage(); + else if (Importer.GetFromTU(Found) == From->getTranslationUnitDecl()) { +if (From->isInAnonymousNamespace()) We don't really need an `else

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

balazske added inline comments. Comment at: unittests/AST/ASTImporterTest.cpp:2523 + Decl *ToTU = ToAST->getASTContext().getTranslationUnitDecl(); + cast(ToTU)->dumpDeclContext(); + ASSERT_EQ(DeclCounter().match(ToTU, functionDecl(hasName("f"))), Is this dump

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong updated this revision to Diff 183523. martong added a comment. - Remove old style import in case of FoundArray Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57232/new/ https://reviews.llvm.org/D57232 Files: include/clang/AST/ASTImporter.h lib/AST/AST

[PATCH] D57232: [ASTImporter] Check visibility/linkage of functions and variables

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. During import of a global variable with external visibility the lookup will find variables (with the same na