[PATCH] D57189: Fix compatibility with the msvc AI compiler option

2019-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352119: [clang-cl] Ignore space-separated /AI arguments (authored by rnk, committed by ). Herald added a subscriber: llvm-

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

2019-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk updated this revision to Diff 183398. rnk added a comment. - add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57189/new/ https://reviews.llvm.org/D57189 Files: clang/include/clang/Driver/CLCompatOptions.td clang/test/Driver/cl-options.c Index: clang/test/Driver/cl-optio

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

2019-01-24 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, I'll go ahead and commit this soon. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57189/new/ https://reviews.llvm.org/D57189 ___

[PATCH] D57189: Fix compatibility with the msvc AI compiler option

2019-01-24 Thread Zachary Henkel via Phabricator via cfe-commits
zahen created this revision. zahen added reviewers: rnk, zturner. Herald added a subscriber: cfe-commits. The unsupported /AI option accepts directory paths in a manner similar to the supported /I option and allows spaces between the flag and the directory. An example snippet from our productio