[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. Regardless, I think it would be fine if you wanted to add a CUDA/HIP exception to this check in the short term. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 _

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. In D57188#1374890 , @yaxunl wrote: > This change causes regressions for CUDA/HIP. As single-source language, > CUDA/HIP code contains both device and host code. It has separate compilation > for host and device. > In host compi

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

yaxunl added a comment. This change causes regressions for CUDA/HIP. As single-source language, CUDA/HIP code contains both device and host code. It has separate compilation for host and device. In host compilation, device function is parsed but not emitted in IR. The device function may have _

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a comment. "it" is the grammatically correct word. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

scanon added a subscriber: ab. scanon added a comment. > do we want to support _Float16 anywhere else? ARM is the only in-tree target with a defined ABI that I'm aware of. > Do we need to lock down an ABI here for i386/x86_64 in advance of those gears > turning in the outer world? We definitel

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL352221: Disable _Float16 for non ARM/SPIR Targets (authored by erichkeane, committed by ). Herald added a subscriber: llvm

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:484 +- SPIR +``_Float16`` will be supported on more targets as they define ABIs for them. + rjmccall wrote: > "them" should be "it" here. Sorry, apparently Phabricator was sitting on a commen

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added a subscriber: scanon. rjmccall added a comment. This LGTM with one minor revision; feel free to commit with that. For follow-up commit consideration: @scanon, do we want to support `_Float16` anywhere else? Do we need to lock down an ABI here for i386/x86_64 in advance of those

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane updated this revision to Diff 183536. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57188/new/ https://reviews.llvm.org/D57188 Files: docs/LanguageExtensions.rst include/clang/Basic/TargetInfo.h lib/Basic/TargetInfo.cpp lib/Basic/Targets/AArch64.cpp lib/Basic/Targets

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane marked 5 inline comments as done. erichkeane added inline comments. Comment at: include/clang/Basic/TargetInfo.h:66 bool HasFloat128; + bool HasFloat16; unsigned char PointerWidth, PointerAlign; SjoerdMeijer wrote: > I think this is the same as

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

SjoerdMeijer added inline comments. Comment at: include/clang/Basic/TargetInfo.h:66 bool HasFloat128; + bool HasFloat16; unsigned char PointerWidth, PointerAlign; I think this is the same as `HasLegalHalfType`, and we can (re)use that. Or, at least, don'

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

rjmccall added inline comments. Comment at: docs/LanguageExtensions.rst:497 defined by the C standards committee, so using ``_Float16`` will not prevent -code from being ported to architectures other than Arm. Also, ``_Float16`` -arithmetic and operations will directly map on h

[PATCH] D57188: Disable _Float16 for non ARM/SPIR Targets

erichkeane created this revision. erichkeane added reviewers: rjmccall, andrew.w.kaylor. Herald added subscribers: kristof.beyls, javed.absar. As Discussed here: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129543.html There are problems exposing the _Float16 type on architectures that h