rnk added a comment.
Thanks for following up!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57114/new/
https://reviews.llvm.org/D57114
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rC352307: Remove Expr sugar decorating the CXXUuidofExpr node.
(authored by void, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D57114?vs=183180&id=183750#toc
Repository:
rC Clang
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: lib/Sema/SemaTemplate.cpp:6311
if (isa(E)) {
- Converted = TemplateArgument(ArgResult.get());
+ Converted = Templat
riccibruno added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:6311
if (isa(E)) {
- Converted = TemplateArgument(ArgResult.get());
+ Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts());
break;
A remark wh
void updated this revision to Diff 183180.
void added a comment.
Move test to proper place and add "-verify" flag.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D57114/new/
https://reviews.llvm.org/D57114
Files:
lib/Sema/SemaTemplate.cpp
test/SemaCXX/PR40395.
void marked 2 inline comments as done.
void added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:6311
if (isa(E)) {
- Converted = TemplateArgument(ArgResult.get());
+ Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts());
br
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:6311
if (isa(E)) {
- Converted = TemplateArgument(ArgResult.get());
+ Converted = TemplateArgument(ArgResult.get()->IgnoreImpCasts());
break;
`IgnoreP
void created this revision.
void added a reviewer: rsmith.
Herald added a subscriber: cfe-commits.
Sugar, like ConstantExpr, causes an infinite expansion of the template object.
Repository:
rC Clang
https://reviews.llvm.org/D57114
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/pr40395.