[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

This revision was automatically updated to reflect the committed changes. Closed by commit rL355132: [clang-tidy] add OverrideMacro to modernize-use-override check (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D57087?vs=18

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

JonasToth accepted this revision. JonasToth added a comment. LGTM Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:196 + ReplacementText = " " + OverrideSpelling + " "; +} } else if (GetText(Tokens.back(), Sources) == "ABSTRACT") {

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 188752. MyDeveloperDay added a comment. rebase after D58731: [clang-tidy] added cppcoreguidelines-explicit-virtual-functions change as this was previous accepted I will land shortly, but I'd appreciate a quick overv

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

lewmpk added a comment. I'm happy to land this ASAP but I don't have commit rights CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Sorry for the delay. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 ___ cfe-commits mailin

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added a comment. In D57087#1400578 , @malcolm.parsons wrote: > Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's > macro automatically. This would be a neat trick, but mainly I think users would either be usin

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

malcolm.parsons added a comment. Some Clang warnings use PP.getLastMacroWithSpelling() to determine the user's macro automatically. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 ___ cfe-commits ma

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 187155. MyDeveloperDay marked 10 inline comments as done. MyDeveloperDay added a comment. Address review comments - change OverrideMacro to OverrideSpelling - change FinalMacro to FinalSpelling - fix unit tests - show warning without fix-it if Macros a

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Herald added a subscriber: jdoerfert. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Option

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 183268. MyDeveloperDay marked 12 inline comments as done. MyDeveloperDay added a comment. Addressing review comments, - reduce changes causing excessive string concats and problems with temporaries - simplify cxx version and macro checks CHANGES SINC

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:32 +: ClangTidyCheck(Name, Context), + OverrideMacro(Options.get("OverrideMacro", "override")), + FinalMacro(Options.get("FinalMacro", "final")) {} alexfh wr

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay added a comment. In D57087#1367610 , @alexfh wrote: > I tend to think that a better migration strategy is to change the compiler to > a C++11-compatible one first, and then turn on C++11 mode and migrate the > code (possibly file-by-file o

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

JonasToth added inline comments. Comment at: clang-tidy/modernize/UseOverrideCheck.cpp:133 +StringRef Correct = +HasFinal ? "'" + FinalMacro + "'" : "'" + OverrideMacro + "'"; Dangling? These values seem to be temporary and `StringRef` would bind to

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. I tend to think that a better migration strategy is to change the compiler to a C++11-compatible one first, and then turn on C++11 mode and migrate the code (possibly file-by-file or

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay updated this revision to Diff 183063. MyDeveloperDay added a comment. Adding release note change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57087/new/ https://reviews.llvm.org/D57087 Files: clang-tidy/modernize/UseOverrideCheck.cpp clang-tidy/modernize/UseOverride

[PATCH] D57087: [clang-tidy] add OverrideMacro to modernize-use-override check

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: alexfh, JonasToth, hokein, Eugene.Zelenko, aaron.ballman. MyDeveloperDay added a project: clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. The usefulness of **modernize-use-override** can be reduced if you h