[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman closed this revision. aaron.ballman added a comment. I needed to make some minor alterations to your patch. The CXX DR status page is automatically generated and I didn't remember that. I went and added an additional test case and did the automated DR regeneration. I've commit in

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov marked an inline comment as done. loskutov added a comment. Yes, I'm not able to commit by myself, so it would be nice if you did that. Apache 2.0 with LLVM Exceptions is fine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182792. loskutov edited the summary of this revision. loskutov added a comment. Reflected the change in cxx_dr_status.html and specified `-std=c++17` for the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Aside from the DR status page and a nit with the test's RUN line, this LGTM. Thank you for working on this -- do you need me to commit on your behalf? If so, are you aware of the

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182783. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp clang/test/AST/ast-dump-expr.cpp clang/test/CXX/expr/expr.prim/expr.prim.lambda/p9.cpp Index: clang/test/CX

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182782. loskutov marked an inline comment as done. loskutov added a comment. Uploaded an updated diff instead of a diff-from-previous-diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

loskutov updated this revision to Diff 182779. loskutov added a comment. Fixed the comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56992/new/ https://reviews.llvm.org/D56992 Files: clang/lib/Sema/SemaLambda.cpp Index: clang/lib/Sema/SemaLambda.cpp ===

[PATCH] D56992: [clang] Mark lambda-to-function-pointer conversion as noexcept

aaron.ballman edited reviewers, added: rsmith; removed: llvm-commits, doug.gregor. aaron.ballman added a comment. > Pre-C++17 standards don't have this requirement; however, they don't forbid > the conversion functions to have this specification either. This change happened as a result of DR 17