[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-27 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Backporting to 8.0.0 is possibly possible, you'll need to ping Hans. I don't know about previous versions though. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974 _

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-27 Thread Nicolas Lesser via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352323: [SemaCXX] Fix ICE with structure bindings to members of template (authored by Rakete, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.o

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-27 Thread Daniele Di Proietto via Phabricator via cfe-commits
ddiproietto added a comment. Sorry, I don't have commit access, can someone push this, please? Also, should this be backported to 8.x? I'm actually interested in a backport up to 5.x, if possible. If not possible, that's fine too. Thanks! Cheers, Daniele Repository: rC Clang CHANGES SINCE

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-26 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974 ___ cfe-c

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-20 Thread Nicolas Lesser via Phabricator via cfe-commits
Rakete added a comment. Yeah, seems like we don't instantiate `pair` at all in that specific case. LGTM but you might want to wait for someone else to confirm. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56974/new/ https://reviews.llvm.org/D56974 __

[PATCH] D56974: [SemaCXX] Fix ICE with structure bindings to members of template

2019-01-20 Thread Daniele Di Proietto via Phabricator via cfe-commits
ddiproietto created this revision. ddiproietto added a reviewer: clang. ddiproietto added a project: clang. Herald added a subscriber: cfe-commits. Trying to use structure binding with a structure that doesn't implement std::tuple_size, should unpack the data members. When the struct is a template