This revision was automatically updated to reflect the committed changes.
Closed by commit rL353212: Do not use frame pointer by default for MSP430
(authored by asl, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST AC
asl accepted this revision.
asl added a comment.
This revision is now accepted and ready to land.
Herald added a project: clang.
Ok now
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https://reviews.llvm.org/D56925
___
dmikushin updated this revision to Diff 184116.
dmikushin edited the summary of this revision.
dmikushin added a comment.
Unbreaking clang driver patch. Not using calla asm instruction, as recomended.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https
krisb added inline comments.
Comment at: test/CodeGen/msp430-fp-elim.c:16
+{
+ asm volatile ("calla r4");
+}
This test as it is will fail after integrated assembler will be turned on by
default (see https://reviews.llvm.org/D56787). Since `calla` instruct
asl requested changes to this revision.
asl added a comment.
This revision now requires changes to proceed.
Patch fails to apply. Please rebase.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https://reviews.llvm.org/D56925
__
grimar added a comment.
Thanks for adding a test case! I know not enough about msp430/clang to verify
it, unfortunately.
(I just asked for a test because it is always useful to have one for any
non-NFC patch).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/
dmikushin updated this revision to Diff 182998.
dmikushin added a comment.
@grimar Please find the updated patch with a test case.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https://reviews.llvm.org/D56925
Files:
lib/Driver/ToolChains/Clang.cpp
grimar added a comment.
Testcase?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56925/new/
https://reviews.llvm.org/D56925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
dmikushin created this revision.
Herald added a subscriber: cfe-commits.
dmikushin added a reviewer: asl.
> 3.3.9 Frame Pointer
> MSP430 does not use a frame pointer. This effectively limits a single call
> frame to 0x7fff bytes, which is the minimum SP offset supported by any
> instruction
We
