[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351793: [clangd] NFC: Use buildCompilerInvocation in CodeComplete (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56860?vs=182856&id=182865#toc Repository:

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thank you! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56860/new/ https://reviews.llvm.org/D56860

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet updated this revision to Diff 182856. kadircet marked 2 inline comments as done. kadircet added a comment. - Moved ParseInputs and buildCompilerInvocation into Compiler.h Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56860/new/ https://revi

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

sammccall added a comment. In D56860#1365432 , @ilya-biryukov wrote: > Adding Sam as a reviewer, IIRC we used to have `buildCompilerInvocation` here > and he was the one who inlined it. > I would personally LGTM this change (with the two comments fixed)

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

ilya-biryukov added a reviewer: sammccall. ilya-biryukov added a comment. Adding Sam as a reviewer, IIRC we used to have `buildCompilerInvocation` here and he was the one who inlined it. I would personally LGTM this change (with the two comments fixed), but Sam might have a different opinion on

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

ilya-biryukov added inline comments. Comment at: clangd/CodeComplete.cpp:1030 auto &FrontendOpts = CI->getFrontendOpts(); FrontendOpts.DisableFree = false; FrontendOpts.SkipFunctionBodies = true; remove this line, `buildCompilerInvocation` handles this f

[PATCH] D56860: [clangd] NFC: Use buildCompilerInvocation in CodeComplete

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ioeric. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56860 Files: clangd/CodeComplete.cpp Index: clangd/CodeComplete.cpp