[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

2019-01-18 Thread Sam Parker via Phabricator via cfe-commits
samparker updated this revision to Diff 182481. samparker added a comment. Updated wsr, rsr and rbit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews.llvm.org/D56852 Files: include/clang/Basic/BuiltinsAArch64.def test/CodeGen/arm64-crc32.c test/CodeGen/bui

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

2019-01-17 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added a comment. While you're here, can you also fix `__builtin_arm_rbit64`, `__builtin_arm_rsr64`, and `__builtin_arm_wsr64`? Comment at: include/clang/Basic/BuiltinsAArch64.def:54 +BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc") +BUILTIN(__builtin_arm_crc32cd, "UiUi

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

2019-01-17 Thread Reid Kleckner via Phabricator via cfe-commits
rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:54 +BUILTIN(__builtin_arm_crc32d, "UiUiLLUi", "nc") +BUILTIN(__builtin_arm_crc32cd, "UiUiLLUi", "nc") If we can't change the signature on Linux (I don't see any reason why couldn't,

[PATCH] D56852: [AArch64] Use LLU for 64-bit crc32 arguments

2019-01-17 Thread Sam Parker via Phabricator via cfe-commits
samparker created this revision. samparker added a reviewer: t.p.northover. Herald added subscribers: kristof.beyls, javed.absar. The ACLE states that 64-bit crc32 operands are uint64_t so we should have the clang builtin match this description - which is what we already do for AArch32. https:/