[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-29 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL352463: [AArch64] Update int64_t ACLE builtin arguments (authored by sam_parker, committed by ). Changed prior to commit: https://reviews.llvm.org/D56852?vs=183820&id=184031#toc Repository: rL LLVM

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-28 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews.llvm.org/D56852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-28 Thread Sam Parker via Phabricator via cfe-commits
samparker updated this revision to Diff 183820. samparker added reviewers: phosek, rnk. samparker added a comment. Changed the builtins to use W instead of LL. I've also updated the tests, adding a test for rbitl. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56852/new/ https://reviews

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. This broke our kernel build which uses `PRIx64` to print the return value of `__builtin_arm_rsr64`. This is correct because according to ACLE, the return type of that builtin should be `uint64_t`. Problem is that on AArch64, `unsigned long` is equivalent to `uint64_t`, n

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-21 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351740: [AArch64] Use LL for 64-bit intrinsic arguments (authored by sam_parker, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56852?vs=1824

[PATCH] D56852: [AArch64] Use LL for 64-bit arguments

2019-01-18 Thread Eli Friedman via Phabricator via cfe-commits
efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: test/CodeGen/builtins-arm64.c:2 // RUN: %clang_cc1 -triple arm64-unknown-linux -disable-O0-optnone -emit-llvm -o - %s | opt -S -mem2reg | FileCheck %s