[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

2019-01-21 Thread Eli Friedman via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL351766: [CodeGen] Always use string computed in Sema for PredefinedExpr (authored by efriedma, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

2019-01-16 Thread John McCall via Phabricator via cfe-commits
rjmccall added a comment. I agree that this is the right thing to do. If we want to make those improvements, they're doable within Sema. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56821/new/ https://reviews.llvm.org/D56821

[PATCH] D56821: [CodeGen] Always use string computed in Sema for PredefinedExpr

2019-01-16 Thread Eli Friedman via Phabricator via cfe-commits
efriedma created this revision. efriedma added reviewers: rjmccall, rsmith. We can't use any other string, anyway, because its type wouldn't match the type of the PredefinedExpr. With this change, we don't compute a "nice" name for the __func__ global when it's used in the initializer for a con