This revision was automatically updated to reflect the committed changes.
Closed by commit rC351368: [Fixed Point Arithmetic] Add APFixedPoint to APValue
(authored by leonardchan, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D56746?vs=181918&id=182103#toc
Repository:
rC
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56746/new/
https://reviews.llvm.org/D56746
___
c
leonardchan updated this revision to Diff 181918.
leonardchan marked an inline comment as done.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56746/new/
https://reviews.llvm.org/D56746
Files:
clang/include/clang/AST/APValue.h
clang/include/clang/AST/Type.h
c
rjmccall added a comment.
One nit-pick, then this is good to go.
Comment at: clang/include/clang/AST/APValue.h:183
+setFixedPoint(std::move(FX));
+ }
explicit APValue(const APValue *E, unsigned N) : Kind(Uninitialized) {
I know this is the established p
leonardchan added a comment.
Regarding tests, I couldn't actually find any under clang/unittests that test
APValue specifically. Is it worth it to add some still?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56746/new/
https://reviews.llvm.org/D56746
___
leonardchan created this revision.
leonardchan added reviewers: rjmccall, ebevhan, bjope.
leonardchan added a project: clang.
This adds APFixedPoint to the union of values that can be represented with an
APValue.
Repository:
rC Clang
https://reviews.llvm.org/D56746
Files:
clang/include/cl
