krisb added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5388
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_msp430_interrupt_attribute)
aaron.ballman wrote:
> What should happen if the f
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5388
+
+ if (hasFunctionProto(D) && getFunctionOrMethodNumParams(D) != 0) {
+S.Diag(D->getLocation(), diag::warn_msp430_interrupt_attribute)
What should happen if the function does no
This revision was automatically updated to reflect the committed changes.
Closed by commit rL351344: [MSP430] Improve support of 'interrupt'
attribute (authored by asl, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm
krisb updated this revision to Diff 181866.
krisb added a comment.
Addressed feedback.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56663/new/
https://reviews.llvm.org/D56663
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/TargetInfo.cpp
lib
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280
+def warn_msp430_interrupt_attribute : Warning<
+ "MSP430 'interrupt' attribute only applies to functions that have "
+ "%select{no parameters|a 'void' return type}0">,
+ InG
krisb added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280
+def warn_msp430_interrupt_attribute : Warning<
+ "MSP430 'interrupt' attribute only applies to functions that have "
+ "%select{no parameters|a 'void' return type}0">,
+ InGroup;
--
aaron.ballman added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:277-280
+def warn_msp430_interrupt_attribute : Warning<
+ "MSP430 'interrupt' attribute only applies to functions that have "
+ "%select{no parameters|a 'void' return type}0">,
+ InG
grimar added inline comments.
Comment at: lib/Sema/SemaDeclAttr.cpp:5381
+ // MSP430 'interrupt' attribute is applied to
+ // a function with no parameters and void return type
+ if (!isFunctionOrMethod(D)) {
nit: code comments usually have a dot `.` at the en
krisb created this revision.
Herald added a subscriber: cfe-commits.
krisb edited the summary of this revision.
krisb added a reviewer: asl.
krisb edited the summary of this revision.
- Accept as an argument constants in range 0..63 (aligned with TI headers and
linker scripts provided with TI GCC
