martong added a comment.
> @martong have you had a chance to look at this some more? We ran into another
> problem that this fixes partially.
I didn't have time to deal with this yet (these days we are preparing an
internal release and that took away my time).
> Can I help in any way?
I think
shafik added a comment.
@martong have you had a chance to look at this some more? We ran into another
problem that this fixes partially. Can I help in any way?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56581/new/
https://reviews.llvm.org/D56581
__
shafik added a subscriber: aprantl.
shafik added a comment.
I don't believe it is directly related to modules but that it just triggers the
issue because it may be bringing in more. You can find a description here
https://clang.llvm.org/docs/CommandGuide/clang.html#cmdoption-g and @aprantl
poin
martong added a comment.
@shafik Ok, I'll take a look into the regression soon. What are exactly
gmodules? Is it macOS only? Do you have a description or some docs about it?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56581/new/
https://reviews.llvm.org/D56581
shafik added a comment.
@martong Unfortunately this causes a regression on one of the lldb tests
`TestDataFormatterLibcxxVector.py` e.g.
lldb-dotest -p TestDataFormatterLibcxxVector.py -t -G gmodules
--no-multiprocess
So this is specific to modules. If you can't reproduce this I can provide
a_sidorin added a comment.
Hello Gabor,
This looks good, but as Shafik mentioned, adding a test would be nice.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56581/new/
https://reviews.llvm.org/D56581
___
cfe-commits
shafik added a comment.
Can you add a test?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56581/new/
https://reviews.llvm.org/D56581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
martong created this revision.
martong added reviewers: shafik, a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Herald added a reviewer: a.sidorin.
During the addition of an injected class type to a record it may happen
that a CXXRecordDecl in the redecl c
