[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

2019-01-09 Thread Heejin Ahn via Phabricator via cfe-commits
aheejin added inline comments. Comment at: include/clang/Basic/BuiltinsWebAssembly.def:53 // Saturating fp-to-int conversions -BUILTIN(__builtin_wasm_trunc_saturate_s_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc_saturate_u_i32_f32, "if", "nc") -BUILTIN(__builtin_wasm_trunc

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

2019-01-09 Thread Thomas Lively via Phabricator via cfe-commits
tlively updated this revision to Diff 180989. tlively marked 3 inline comments as done. tlively added a comment. - Fix formatting, fix and test macro name Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56504/new/ https://reviews.llvm.org/D56504 Files: include/c

[PATCH] D56504: [WebAssembly] Add simd128-unimplemented feature, gate builtins

2019-01-09 Thread Thomas Lively via Phabricator via cfe-commits
tlively added inline comments. Comment at: lib/Basic/Targets/WebAssembly.cpp:89 +// features control availability of builtins +setSIMDLevel(Features, SIMDLevel); +if (HasNontrappingFPToInt) aheejin wrote: > Minor thing, but should we extract this as a