sammccall added a comment.
I think the design should be more thoroughly considered here.
- what are the latency consequences of the extra index lookup in different
scenarios?
- how does this compare to doing it at LSP resolve time instead?
- if we're going to do the extra lookup, can we make use
hokein updated this revision to Diff 181009.
hokein marked 3 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56492/new/
https://reviews.llvm.org/D56492
Files:
clangd/CodeComplete.cp
ilya-biryukov added inline comments.
Comment at: clangd/CodeComplete.cpp:1373
// Convert the results to final form, assembling the expensive strings.
-for (auto &C : Top) {
- Output.Completions.push_back(toCodeCompletion(C.first));
- Output.Completions.back().S
hokein updated this revision to Diff 180843.
hokein added a comment.
Add a comment.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56492/new/
https://reviews.llvm.org/D56492
Files:
clangd/CodeComplete.cpp
unittests/clangd/CodeCompleteTests.cpp
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric.
We are missing docs for class member completion -- we don't store
comments in the preamble, so Sema doesn't return any docs. To get docs
for class members,
