[PATCH] D56380: [clangd] Fix a regression issue caused by r348365.

2019-01-07 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE350515: [clangd] Fix a regression issue caused by r348365. (authored by hokein, committed by ). Changed prior to commit: https://reviews.llvm.org/D56380?vs=180447&id=180460#toc Repository: rCTE Cla

[PATCH] D56380: [clangd] Fix a regression issue caused by r348365.

2019-01-07 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56380/new/ https://reviews.llvm.org/D56380 __

[PATCH] D56380: [clangd] Fix a regression issue caused by r348365.

2019-01-07 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric. With r348365, we now detect libc++ dir using the actual compiler path (from the compilation command), rather than the resource-dir. This new behavior will