steveire marked an inline comment as done.
steveire added inline comments.
Comment at: lib/AST/NestedNameSpecifier.cpp:465
TypeLoc NestedNameSpecifierLoc::getTypeLoc() const {
- assert((Qualifier->getKind() == NestedNameSpecifier::TypeSpec ||
- Qualifier->getKind() ==
This revision was automatically updated to reflect the committed changes.
Closed by commit rL350573: NFC: Replace asserts with if() in SourceLocation
accessors (authored by steveire, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D5635
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from a formatting nit.
Comment at: include/clang/AST/DeclarationName.h:735
+ Name.getNameKind() != DeclarationName::CXXConversionFunctionNa
steveire marked an inline comment as done.
steveire added inline comments.
Comment at: include/clang/AST/DeclarationName.h:735
+ Name.getNameKind() != DeclarationName::CXXConversionFunctionName)
+ return nullptr;
return LocInfo.NamedType.TInfo;
---
steveire updated this revision to Diff 180548.
steveire added a comment.
Fix formatting
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56354/new/
https://reviews.llvm.org/D56354
Files:
include/clang/AST/DeclarationName.h
include/clang/AST/TemplateBase.h
lib
aaron.ballman added a comment.
The downside to this change is that callers now have to check the return values
for validity where they didn't previously because the assertion covered it.
However, I think that's probably reasonable in these cases since they're mostly
returning source locations o
