[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 190789. LegalizeAdulthood added a comment. Herald added a subscriber: jdoerfert. To avoid passing lots of state to/from extracted functions, extract a class instead and use member variables for most of the state CHANGES SINCE LAST ACTION https:/

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

serge-sans-paille added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:103 + return (has_check_fixes, has_check_messages, has_check_notes, \ +check_fixes_prefixes, check_messages_prefixes, check_notes_prefixes) Such a long list of returne

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

JonasToth added a comment. In D56343#1347352 , @LegalizeAdulthood wrote: > I really want to get these reviewed quickly. Otherwise, I will run out of > available time to complete them and get them submitted. I will give my best to be available this wee

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood added a comment. I really want to get these reviewed quickly. Otherwise, I will run out of available time to complete them and get them submitted. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

JonasToth added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:112 +process_output = e.output.decode() +print('%s failed:\n%s' % (' '.join(args), process_output)) +if raise_error: Its better to use `.format()` instead of `%` syntax

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood updated this revision to Diff 180349. LegalizeAdulthood added a comment. Extract Function try_run CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 Files: test/clang-tidy/check_clang_tidy.py Index: test/clang-tidy/check_clang_

[PATCH] D56343: [clang-tidy] Refactor: Compose Method on check_clang_tidy.py

LegalizeAdulthood created this revision. LegalizeAdulthood added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a reviewer: serge-sans-paille. Break up the huge main() function Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56343 Files: test/clang-tidy