[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL350171: [gn build] Make `ninja check-clang` also run Clang's unit tests (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D561

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179744. thakis marked 2 inline comments as done. thakis added a comment. comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 Files: llvm/utils/gn/build/BUILDCONFIG.gn llvm/utils/gn/build/sync_source_

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis added a comment. Thanks for the fast turnaround! Comment at: llvm/utils/gn/secondary/llvm/utils/unittest/unittest.gni:34 +# out/gn/obj/clang/unittests/Format/FormatTests, which seems fine. +output_dir = target_out_dir +deps += [ phosek wrote:

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

phosek added inline comments. Comment at: llvm/utils/gn/secondary/llvm/utils/unittest/unittest.gni:34 +# out/gn/obj/clang/unittests/Format/FormatTests, which seems fine. +output_dir = target_out_dir +deps += [ What if someone explicitly sets `output_d

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179736. thakis edited the summary of this revision. thakis added a comment. Add unittest template. This is now ready to go. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56116/new/ https://reviews.llvm.org/D56116 Files: llvm/utils/gn/build/BUILDCO

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis updated this revision to Diff 179667. thakis edited the summary of this revision. thakis added a comment. Herald added a subscriber: mgorny. - add test BUILD.gn support to sync script - remove bigobj fixme since that issue isn't specific to that file CHANGES SINCE LAST ACTION https://re

[PATCH] D56116: [gn build] Make `ninja check-clang` also run Clang's unit tests

thakis created this revision. thakis added a reviewer: phosek. Herald added a subscriber: arphaman. Also add a build file for clang/lib/ASTMatchers/Dynamic, which is only needed by tests (and clang/tools/extra). With this, the build files for //clang are complete. - I'm sending this out before