[PATCH] D56065: [gn build] Make NOSORT line actually work

2018-12-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL350060: [gn build] Make NOSORT line actually work (authored by nico, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56065?vs=179474&id=179480

[PATCH] D56065: [gn build] Make NOSORT line actually work

2018-12-24 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56065/new/ https://reviews.llvm.org/D56065 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56065: [gn build] Make NOSORT line actually work

2018-12-24 Thread Nico Weber via Phabricator via cfe-commits
thakis created this revision. thakis added a reviewer: phosek. GN wants the NOSORT line to be the first line of a comment block, not the last line. I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in the last line too, but since it will be a while until everyone has th