[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-23 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL350028: [Driver] Disable -faddrsig on Gentoo by default (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56047?vs=179415&i

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-23 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D56047#1340337 , @phosek wrote: > LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in > the commit message for reference? Done, and thanks for the review. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-23 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM, would it be possible to also include https://bugs.gentoo.org/667854 in the commit message for reference? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-23 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. It was disabled on NetBSD for the same reason - GNU strip(1) is breaking: http://netbsd.org/~kamil/llvm/strip.txt Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56047/new/ https://reviews.llvm.org/D56047 ___

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-22 Thread Michał Górny via Phabricator via cfe-commits
mgorny added a comment. In D56047#1340303 , @phosek wrote: > Just a comment regarding the description, are you sure it's GNU strip and not > as? Yes. https://bugs.gentoo.org/667854 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-22 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. Just a comment regarding the description, are you sure it's GNU strip and not as? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56047/new/ https://reviews.llvm.org/D56047 ___ cfe-commits mail

[PATCH] D56047: [Driver] Disable -faddrsig on Gentoo by default

2018-12-22 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: pcc, dyung, phosek. Gentoo supports combining clang toolchain with GNU binutils, and many users actually do that. As -faddrsig is not supported by GNU strip, this results in a lot of warnings. Disable it by default and let users enable it exp