[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

2018-12-23 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL350027: [Distro] Support detecting Gentoo (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56024?vs=179413&id=179441#toc

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

2018-12-22 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 179413. mgorny added a comment. Now with `IsGentoo()` predicate. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56024/new/ https://reviews.llvm.org/D56024 Files: include/clang/Driver/Distro.h lib/Driver/Distro.cpp unittests/Driver/DistroTest.cp

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

2018-12-22 Thread Michał Górny via Phabricator via cfe-commits
mgorny marked an inline comment as done. mgorny added inline comments. Comment at: include/clang/Driver/Distro.h:118 } bool IsUbuntu() const { phosek wrote: > Shall we also introduce the `IsGentoo()` predicate for convenience? Hmm, I originally thought th

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

2018-12-21 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: include/clang/Driver/Distro.h:118 } bool IsUbuntu() const { Shall we also introduce the `IsGentoo()` predicate for convenience? Re

[PATCH] D56024: [clang] [Distro] Support detecting Gentoo

2018-12-21 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: sylvestre.ledru, bruno, bkramer, phosek. Add support for distinguishing plain Gentoo distribution, and a unit test for it. This is going to be used to introduce distro-specific customizations in the driver code; most notably, it is going to be