alexfh added a comment.
One random late comment.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/abseil-duration-factory-scale.cpp:38
+ // CHECK-MESSAGES: :[[@LINE-1]]:7: warning: use ZeroDuration() for
zero-length time intervals [abseil-duration-factory-scale]
+ // CHE
This revision was automatically updated to reflect the committed changes.
Closed by commit rL349953: [clang-tidy] Be more liberal about literal zeroes in
abseil checks (authored by hwright, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56012/new/
https://reviews.llvm.org/D56012
___
cfe-commits mailing lis
hwright added a comment.
btw, I think `hasInit` should probably be moved into the core set of matchers
at some point.
Comment at: clang-tidy/abseil/DurationRewriter.cpp:110
+ ast_matchers::internal::Matcher, InnerMatcher) {
+ return (N < Node.getNumInits() &&
+
hwright updated this revision to Diff 179335.
hwright marked 6 inline comments as done.
hwright added a comment.
Add documentation, adjust test.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56012/new/
https://reviews.llvm.org/D56012
Files:
clang-tidy/abseil/DurationFactoryScaleCheck
aaron.ballman added inline comments.
Comment at: clang-tidy/abseil/DurationRewriter.cpp:110
+ ast_matchers::internal::Matcher, InnerMatcher) {
+ return (N < Node.getNumInits() &&
+ InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder,
-
Eugene.Zelenko added inline comments.
Comment at: test/clang-tidy/abseil-duration-factory-scale.cpp:3
+#include
#include "absl/time/time.h"
cstdint, please.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56012/ne
