This revision was automatically updated to reflect the committed changes.
Closed by commit rL349831: [gn build] Add build file for clang/lib/Parse
(authored by nico, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55925?vs=179057&id=17
phosek added a comment.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55925/new/
https://reviews.llvm.org/D55925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thakis created this revision.
thakis added a reviewer: phosek.
Nothing really interesting. One thing to consider is where the clang_tablegen()
invocations that generate files that are private to a library should be. The
CMake build puts them in clang/include/clang/Parse (in this case), but maybe