[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay abandoned this revision. MaskRay added a comment. Herald added a subscriber: jdoerfert. Herald added a project: clang. The DT_GNU_HASH objection is so strong that I think I have to abandon this. I can do nothing but to blame the original sysv hash is so bad (it may be unfair to blame it

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

kib added a comment. I do not like this. The change makes binaries linked by the default toolchain on FreeBSD, non-standard compliant. Several hundred bytes is not too high cost to pay for not having issues with all tools still not adapted to GNU hash (and never be). Repository: rC Clang

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay added a comment. Friendly ping :) (This is related to FreeBSD, not OpenBSD) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

brad added a comment. I've been told there is no desire to make gnu the default on OpenBSD. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 ___ cfe-commits mailing list cfe-co

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay added a comment. In D55878#1339098 , @emaste wrote: > I think the arch-change (switching from a whitelist to a MIPS blacklist) is > reasonable. What is the motivation for dropping `DT_HASH`, just binary size > reduction? Yes. It saves a few hun

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

emaste added a comment. I think the arch-change (switching from a whitelist to a MIPS blacklist) is reasonable. What is the motivation for dropping `DT_HASH`, just binary size reduction? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.l

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

sdardis added a comment. > I can't find rationale behind the MIPS discrepancy in the original commit. I > can add the if branch back if you tell me why... From my recollections, the gnu-hash style isn't supported in ld.bfd for MIPS. A patch was posted to the binutils list (https://sourceware.o

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay updated this revision to Diff 178908. MaskRay edited the summary of this revision. MaskRay added a comment. Bring back MIPS special case Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 Files: lib/Driver/ToolChai

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

atanasyan added inline comments. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:160 +if (ToolChain.getTriple().getOSMajorVersion() >= 9) + CmdArgs.push_back("--hash-style=gnu"); CmdArgs.push_back("--enable-new-dtags"); MaskRay wrote: > I can't find r

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay updated this revision to Diff 178836. MaskRay added a comment. . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55878/new/ https://reviews.llvm.org/D55878 Files: lib/Driver/ToolChains/FreeBSD.cpp test/Driver/freebsd.c Index: test/Driver/freebsd.c ==

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/FreeBSD.cpp:160 +if (ToolChain.getTriple().getOSMajorVersion() >= 9) + CmdArgs.push_back("--hash-style=gnu"); CmdArgs.push_back("--enable-new-dtags");

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

MaskRay created this revision. MaskRay added reviewers: emaste, brooks, dim. Herald added subscribers: cfe-commits, atanasyan, fedor.sergeev, arichardson, sdardis. rtld started to support DT_GNU_HASH since rS234841 (2013). libexec/rtld-elf/rtld.c:symlook_obj uses DT_GNU_HASH when it is present an