[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille marked an inline comment as done. serge-sans-paille added a comment. Herald added a subscriber: llvm-commits. It's in, thanks @rsmith for the review. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

This revision was automatically updated to reflect the committed changes. Closed by commit rL352838: Fix isInSystemMacro to handle pasted macros (authored by serge_sans_paille, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D55782?vs=184275&id=18

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/SourceManager.h:1466 +// its spelling is the scratch memory, so we take the parent context. +if(isWrittenInScratchSpace(getSpellin

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille marked 2 inline comments as done. serge-sans-paille added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch mem

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 184275. serge-sans-paille added a comment. Patch updated to take into account @rsmith remarks. Test case added as an illustration. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

rsmith added inline comments. Comment at: include/clang/Basic/SourceManager.h:1458-1460 + // This happens when the macro is the result of a paste, in that case + // its spelling is the scratch memory, so we take the parent context. +isInSystemHea

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille added a comment. @rsmith up! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D55782: Fix isInSystemMacro to handle pasted token

serge-sans-paille updated this revision to Diff 181498. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55782/new/ https://reviews.llvm.org/D55782 Files: include/clang/Basic/SourceManager.h test/Misc/no-warn-in-system-macr