[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2019-01-07 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg added a comment. In D55775#1338512 , @qcolombet wrote: > Should we emit an error if we request x86_64h with an arch older than haswell? Makes sense. I'll put up a patch soon. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2018-12-20 Thread Quentin Colombet via Phabricator via cfe-commits
qcolombet added a comment. Should we emit an error if we request x86_64h with an arch older than haswell? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775 ___ cfe-commits mailin

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2018-12-17 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL349381: [Driver] Don't override '-march' when using '-arch x86_64h' (authored by thegameg, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D557

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2018-12-17 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775 ___ cfe-commits mailing list cfe-commi

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2018-12-17 Thread Gerolf Hoflehner via Phabricator via cfe-commits
Gerolf added reviewers: ahatanak, qcolombet. Gerolf added a comment. + Akira, Quentin for their driver / x86_64h experience for a quick double check. Fwiw, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55775/new/ https://reviews.llvm.org/D55775

[PATCH] D55775: [Driver] Don't override '-march' when using '-arch x86_64h'

2018-12-17 Thread Francis Visoiu Mistrih via Phabricator via cfe-commits
thegameg created this revision. thegameg added reviewers: vsk, dexonsmith, ab, t.p.northover, Gerolf. On Darwin, using '-arch x86_64h' would always override the option passed through '-march'. This patch allows users to use '-march' with x86_64h, while keeping the default to 'core-avx2' https