[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. As it looks like libc++ isn't going to define the type for earlier dialects, libstdc++ doesn't either (which seems right anyway because the names aren't reserved prior to C++20). We now define the type and variable unconditionally for C++2a, but only define the `__cpp_

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. In D55741#1361040 , @jwakely wrote: > I'd be happy to restrict this to > C++17 only (which is automatically the > case when using G++ because there's no `-fdestroying-delete` to enable it, > you only get it with `-std=c++2a`,

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. I'd be happy to restrict this to > C++17 only (which is automatically the case when using G++ because there's no `-fdestroying-delete` to enable it, you only get it with `-std=c++2a`, `-std=gnu++2a` etc.) Repository: rC Clang CHANGES SINCE LAST ACTION https://rev

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Conditioning off of C++17 (or part C++11 and part C++17) seems reasonable, although we may want consistency with libc++ (discussion on https://reviews.llvm.org/D55840). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

jwakely added a comment. The simplest solution would be to change libstdc++'s `` to: #if __cplusplus >= 201703L && __cpp_impl_destroying_delete #define __cpp_lib_destroying_delete 201806L Or we could be fancier and do: #if __cplusplus >= 201103L && __cpp_impl_destroying_delete namespace

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

rsmith added a comment. @jwakely, we should come to a common understanding of the right behavior here :) (and then probably report back to SG-10). Clang unconditionally makes sized delete work if you have a suitable library type, and expects the library to decide whether it wants to provide the

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

sberg added a comment. One problem I found with the macro `__cpp_impl_destroying_delete` not being conditional on language version is the following: Recent GCC trunk (since https://gcc.gnu.org/git/?p=gcc.git;a=commit;h=76b94d4ba654e9af1882865933343d11f5c3b18b "Implement P0722R3, destroying oper

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

This revision was automatically updated to reflect the committed changes. Closed by commit rC350934: Implementation Feature Test Macros for P0722R3 (authored by ckennelly, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llv

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Yes, I need someone to commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llvm.org/D55741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

rsmith accepted this revision. rsmith added a comment. Thanks! Do you need someone to commit for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llvm.org/D55741 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly updated this revision to Diff 178423. ckennelly added a comment. Added update to cxx_status.html for partial implementation of feature test macros adopted in San Diego CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llvm.org/D55741 Files: lib/Front

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good. Is there anything in www/cxx_status.html that we should update to track that we've implemented this part of P1353R0? Repository: rC Clang CHANGES SINCE LAST ACTION https://re

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly created this revision. ckennelly added a reviewer: rsmith. Herald added a subscriber: cfe-commits. P1353R0, adopted in San Diego, specified an implementation feature test macro for destroying delete (P0722R3). The implementation of the feature (https://reviews.llvm.org/rL315662) is not