[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

This revision was automatically updated to reflect the committed changes. Closed by commit rC352572: [analyzer] NFC: GenericTaintChecker: Revise rule specification mechanisms. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D55734?vs=179436&id=184201#to

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ added a comment. Hmm, the diff is a mixture of D54918 and this patch. I'll apply it by reverting D54918 locally and then applying this diff, but please let us know if you accidentally uploaded a wrong diff! CHANGES SINCE

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 added a comment. Yes, thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. In D55734#1372972 , @boga95 wrote: > Is it ready to land? Whops. Yes, right, it's totally ready to land! Sorry. Should i commit? CHANGES SINCE LAST AC

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 marked 4 inline comments as done. boga95 added a comment. Is it ready to land? Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:212 + llvm::StringSwitch(Name) + .Case("atoi", TaintPropagationRule({0}, {ReturnValueIndex})) + .Case("at

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 updated this revision to Diff 179436. boga95 marked 7 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChec

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

a_sidorin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:156 +bool isDestinationArgument(unsigned ArgNum) const { + return (std::find(DstArgs.begin(), DstArgs.end(), ArgNum) != + DstArgs.end()); llvm::

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

boga95 updated this revision to Diff 178537. boga95 marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChec

[PATCH] D55734: [analyzer] Revise GenericTaintChecker's internal representation

NoQ added a comment. Hi, thanks again for looking into this! I have a single piece of doubt that this doesn't change the behavior (the comment about `pread`), but other than that, this diff is good to go, in my opinion. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChec