[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178373. boga95 added a comment. Rebase patch on the earlier version. Remove unnecessary inline specifiers. Fix typo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/Gener

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added a comment. Hmm, I find the revision title and summary a little vague -- I'd expect a revision called "Refactoring" not to feature any funcitonal change, yet you changed how variadic functions are handled. Please - Keep purely formatting changes to your earlier revision, and reba

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178368. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp =

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 added a comment. I use std::move which is in the ``. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added inline comments. Comment at: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp:210-230 + TaintPropagationRule Rule = + llvm::StringSwitch(Name) + .Case("atoi", TaintPropagationRule({0}, {ReturnValueIndex})) + .Case("atol", TaintPropagatio

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

boga95 updated this revision to Diff 178351. boga95 added a comment. Upload diff with full context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 Files: lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Index: lib/StaticAnalyzer/Checkers/

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

kristina added a comment. If you don't mind, please submit diffs with full context (`diff -U9` or something alike depending on what you use). It makes it much easier to review patches. Also the formatting looks really off in some places where 4 spaces are used. Also another nitpick, nested

[PATCH] D55734: [analyzer] Refactoring GenericTaintChecker.cpp

Szelethus added a comment. Could you please reupload with full context? :) https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55734/new/ https://reviews.llvm.org/D55734 ___