aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:129
+ unsigned Index = 0;
+ for (const json::Value &File : Files) {
+if (const json::Object *Obj = File.getAsObject()) {
---
NoQ added a comment.
Sure, np.
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:129
+ unsigned Index = 0;
+ for (const json::Value &File : Files) {
+if (const json::Object *Obj = File.getAsObject()) {
aaron.ballman wrote:
> NoQ wrote:
> > This sou
aaron.ballman closed this revision.
aaron.ballman added a comment.
Committed in r349188.
(@NoQ -- if you'd like to see a switch to `llvm::find_if()`, I'm happy to
handle it post-commit.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55707/new/
https://reviews.llvm.org/D55707
__
aaron.ballman marked 4 inline comments as done.
aaron.ballman added inline comments.
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:129
+ unsigned Index = 0;
+ for (const json::Value &File : Files) {
+if (const json::Object *Obj = File.getAsObject()) {
---
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Yup, looks good, and i keep passively cheering for this project to be
successful.
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:129
+ unsigned Index = 0;
+ for (const
aaron.ballman marked an inline comment as done.
aaron.ballman added inline comments.
Comment at: lib/StaticAnalyzer/Core/SarifDiagnostics.cpp:218
const PathDiagnosticLocation &P = Piece->getLocation();
+const auto *CP = dyn_cast(Piece.get());
Locations.push_back(cre
aaron.ballman created this revision.
aaron.ballman added reviewers: NoQ, george.karpenkov.
This updates our SARIF support from 10-10 to 11-28. Functional changes include:
- The run.files property is now an array instead of a mapping.
- fileLocation objects now have a fileIndex property specifying
