This revision was automatically updated to reflect the committed changes.
Closed by commit rL349145: [clangd] Fix memory leak in ClangdTests. (authored
by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55702/new/
https://reviews.llvm.org/D55702
___
dstenb added a comment.
With this patch applied we don't see any issues on our end. Thanks for the help!
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55702/new/
https://reviews.llvm.org/D55702
___
cfe-
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added subscribers: arphaman, jkorous, MaskRay, ioeric, ilya-biryukov.
createInvocationFromCommandLine sets DisableFree to true by default,
which leads memory leak in clangd. The fix is to use the
`BuildCompilationInvocation`
