This revision was automatically updated to reflect the committed changes.
Closed by commit rC350528: [analyzer] Pass the correct loc Expr from
VisitIncDecOp to evalStore (authored by r.stahl, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55701?vs=180487&id=180489#toc
Repos
r.stahl added a comment.
I tried adding isGLValue to evalStore and the test suite didn't complain. For
evalLoad (on BoundEx) it failed in pretty much every test. Should the evalStore
assert also go into trunk?
Since the analyzer behavior itself remains unchanged, I don't believe any other
chec
r.stahl updated this revision to Diff 180487.
r.stahl added a comment.
rebased
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55701/new/
https://reviews.llvm.org/D55701
Files:
lib/StaticAnalyzer/Core/ExprEngineC.cpp
unittests/StaticAnalyzer/RegisterCustomChec
NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Thanks! Neat test.
Can we now `assert(LocationE->isGLValue())` in `evalStore()`? What about
`evalLoad()`?
Also, were no other checkers affected? Like, will null pointer dereference
checker now war
r.stahl added a comment.
cfe-dev thread with short discussion:
http://lists.llvm.org/pipermail/cfe-dev/2018-April/057562.html
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55701/new/
https://reviews.llvm.org/D55701
r.stahl created this revision.
r.stahl added reviewers: NoQ, dcoughlin, george.karpenkov.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
The LocationE parameter of evalStore is documented as "The location ex
