[PATCH] D55657: [libcxx] [regex] Use distinct __regex_word on NetBSD

2018-12-16 Thread Michał Górny via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL349293: [regex] Use distinct __regex_word on NetBSD (authored by mgorny, committed by ). Herald added subscribers: llvm-commits, christof. Changed prior to commit: https://reviews.llvm.org/D55657?vs=178

[PATCH] D55657: [libcxx] [regex] Use distinct __regex_word on NetBSD

2018-12-13 Thread Michał Górny via Phabricator via cfe-commits
mgorny updated this revision to Diff 178113. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55657/new/ https://reviews.llvm.org/D55657 Files: include/regex Index: include/regex === --- include/regex +++ include/regex @@ -

[PATCH] D55657: [libcxx] [regex] Use distinct __regex_word on NetBSD

2018-12-13 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski accepted this revision. krytarowski added a comment. This revision is now accepted and ready to land. OK, I got it: `#define _CTYPE_Q0x2000 /* Phonogram */` from /usr/include/sys/ctype_bits.h I propose to mention the symbol name in the description and the header. In the de

[PATCH] D55657: [libcxx] [regex] Use distinct __regex_word on NetBSD

2018-12-13 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Where and what defines 0x2000, what header and what symbol name? Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55657/new/ https://reviews.llvm.org/D55657 ___ cfe-commits mailing list c

[PATCH] D55657: [libcxx] [regex] Use distinct __regex_word on NetBSD

2018-12-13 Thread Michał Górny via Phabricator via cfe-commits
mgorny created this revision. mgorny added reviewers: krytarowski, howard.hinnant, dsanders, EricWF. Herald added subscribers: libcxx-commits, ldionne. NetBSD defines character classes up to 0x2000. Use 0x8000 as a safe __regex_word that hopefully will not collide with other values in the foresee