[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

2018-12-12 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. FYI, CMake target property `INTERFACE_SOURCES` is designed to make this easy. For each module you would generate a file containing extern volatile int ${MODULE_NAME}ModuleAnchorSource; static int LLVM_ATTRIBUTE_UNUSED ${MODULE_NAME}ModuleAnchorDestination = ${

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

2018-12-12 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Thanks, LG. You probably may want to wait a bit (a day?) in case others want to comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D555

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

2018-12-12 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan updated this revision to Diff 177832. yvvan marked an inline comment as done. yvvan added a comment. Add standard prologue to the new header CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D55595 Files: clang-tidy/ClangTidyForceLinker.h clang

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

2018-12-12 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tidy/ClangTidyForceLinker.h:1 +#include "llvm/Support/Compiler.h" + Standard prologue missing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55595/new/ https://reviews.llvm.org/D55595 _

[PATCH] D55595: Share the forced linking code between clang-tidy tool and plugin

2018-12-12 Thread Ivan Donchevskii via Phabricator via cfe-commits
yvvan updated this revision to Diff 177829. yvvan retitled this revision from "Add missing bugprone checks to clang-tidy plugin" to "Share the forced linking code between clang-tidy tool and plugin". yvvan edited the summary of this revision. Herald added a subscriber: srhines. CHANGES SINCE LAST