t.p.northover closed this revision.
t.p.northover added a comment.
Thanks JF. Finally pushed it today:
To github.com:llvm/llvm-project.git
9f3fdb0d7fab..5cf58768cb3b master -> master
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55562/new/
https://reviews.ll
t.p.northover added a comment.
Ping.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55562/new/
https://reviews.llvm.org/D55562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
t.p.northover updated this revision to Diff 198452.
t.p.northover added a comment.
Sorry, I managed to forget about this one somehow. I hadn't changed the 32-bit
requirement, but I agree it shouldn't be there so this diff removes it and adds
tests for the newly legal cases.
Repository:
rC Cl
algrant added a comment.
Herald added a project: clang.
Some targets (e.g. AArch64) support 8-bit, 16-bit and 64-bit atomics. max/min
in Clang 7.0 only supported 32-bit max/min, even though the other atomics
supported multiple widths. Is the intention here to support all (four) offered
widths,
t.p.northover added a comment.
> What does it do with floating-point inputs?
Same as all the other atomics: run screaming for the hills (or error out, in
more reasonable terms). The only way to implement floating atomics in LLVM IR
would be with a compare-exchange loop and Clang doesn't expose
jfb added a comment.
What does it do with floating-point inputs?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55562/new/
https://reviews.llvm.org/D55562
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:/
t.p.northover created this revision.
t.p.northover added reviewers: delena, yaxunl.
Herald added subscribers: jfb, mcrosier.
We seem to have been gradually growing support for atomic min/max operations
(exposing longstanding IR atomicrmw instructions). But until now there have
been gaps in the e
