[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325960 , @Eugene.Zelenko wrote: > By the word, will be good idea to have script which check alphabetical order > and use it during build. Sometimes alphabetical order may be violated after > merge with trunk. I th

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

Eugene.Zelenko added a comment. By the word, will be good idea to have script which check alphabetical order and use it during build. Sometimes alphabetical order may be violated after merge with trunk. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ ht

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

This revision was automatically updated to reflect the committed changes. Closed by commit rL348793: [clang-tidy] insert release notes for new checkers alphabetically (authored by JonasToth, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. In D55508#1325834 , @MyDeveloperDay wrote: > In D55508#1325758 , @JonasToth wrote: > > > LGTM. Do you have commit access? > > > I do not I'm afraid I will commit for you. CHANGES SINC

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay added a comment. In D55508#1325758 , @JonasToth wrote: > LGTM. Do you have commit access? I do not I'm afraid CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 __

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. LGTM. Do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 ___ cfe-

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay marked 3 inline comments as done. MyDeveloperDay added a comment. In D55508#1325670 , @JonasToth wrote: > I think this patch is fine, AFAIK these utility scripts are not tested > directly but are just adjusted if they dont work as expected

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added a comment. I think this patch is fine, AFAIK these utility scripts are not tested directly but are just adjusted if they dont work as expected :) Did you test it with a fake new-check? If it does what we expect its fine :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay updated this revision to Diff 177538. MyDeveloperDay added a comment. Fix review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 Files: clang-tidy/add_new_check.py Index: clang-tidy/add_new_check.py ==

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

JonasToth added inline comments. Comment at: clang-tidy/add_new_check.py:213 match = re.search('Improvements to clang-tidy', line) +match_next = re.search('Improvements to include-fixer', line) +match_checker = re.search('- New :doc:`(.*)', line)

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

MyDeveloperDay added a comment. In D55508#1325316 , @Eugene.Zelenko wrote: > Thank you for this fix! Your welcome, I was reviewing other revisions to try and get up to speed, and I saw you giving someone else the same comment you gave mine! I'm no pyt

[PATCH] D55508: [clang-tidy] insert release notes for new checkers alphabetically

Eugene.Zelenko added a comment. Thank you for this fix! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55508/new/ https://reviews.llvm.org/D55508 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l