[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

MaskRay added a comment. In D55484#1760432 , @shi-yan wrote: > I'm hitting a crash by this code, > > getting: > > exception thrown: RuntimeError: unreachable,RuntimeError: unreachable > at ComputeLineNumbers(clang::DiagnosticsEngine&, > clang::Src

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

shi-yan added a comment. Herald added a project: LLVM. I'm hitting a crash by this code, getting: exception thrown: RuntimeError: unreachable,RuntimeError: unreachable at ComputeLineNumbers(clang::DiagnosticsEngine&, clang::SrcMgr::ContentCache*, llvm::BumpPtrAllocatorImpl&, clang::Sour

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

This revision was automatically updated to reflect the committed changes. Closed by commit rL348777: ComputeLineNumbers: delete SSE2 vectorization (authored by MaskRay, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

MaskRay added a comment. In D55484#1324983 , @bkramer wrote: > The performance difference on preprocessing huge files was tiny back then, > doesn't surprise me that it disappeared. What did you test this on? I tested it on cat lib/Sema/*.cpp lib/Code

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. The performance difference on preprocessing huge files was tiny back then, doesn't surprise me that it disappeared. What did you test this on? Dropping it is fine with me. Repository: rC

[PATCH] D55484: ComputeLineNumbers: delete SSE2 vectorization

MaskRay created this revision. MaskRay added a reviewer: bkramer. Herald added a subscriber: cfe-commits. SSE2 vectorization was added in 2012, but it is 2018 now and I can't observe any performance boost with the existing _mm_movemask_epi8 or the following SSE4.2 (compiling with -msse4.2): __