This revision was automatically updated to reflect the committed changes.
Closed by commit rL348628: [test] Fix reproduce-blackslash.s test with NetBSD
tar (authored by mgorny, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55441?vs=177232&id=177251#toc
Repository:
rL LLV
krytarowski added a comment.
bsdtar is libarchive (by BSD people too)
We can align our native tar later and land this as is.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55441/new/
https://reviews.llvm.org/D55441
_
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
We might be able to change NetBSD's tar but I guess that takes very long time.
This test is not very important in the sense that this tests just test a corner
case. So I think we should just
ruiu added a comment.
I thought NetBSD's tar is bsdtar because it's BSD... Anyways, I think I'm fine
with this change, as the new test (which matches both `foo\\.o` and `foo\.o`)
does not match a string that we don't want it to match.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
krytarowski added a comment.
In my opinion it's better to set UNSUPPORTED and align the NetBSD tar to GNU
tar and libarchive.
Repository:
rLLD LLVM Linker
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55441/new/
https://reviews.llvm.org/D55441
mgorny created this revision.
mgorny added reviewers: krytarowski, bkramer, ruiu, davide.
mgorny added a project: lld.
Herald added subscribers: llvm-commits, MaskRay, arichardson, emaste.
Herald added a reviewer: espindola.
Unlike GNU tar and libarchive bsdtar, NetBSD 'tar -t' output does not
use
