[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-12 Thread Shyan Akmal via Phabricator via cfe-commits
Naysh marked an inline comment as done. Naysh added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail aaron.ballman

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-11 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Eugene.Zelenko wrote: > Naysh wrote: > > Euge

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-10 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Naysh wrote: > Eugene.Zelenko wrote: > > Mis

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-10 Thread Shyan Akmal via Phabricator via cfe-commits
Naysh added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Eugene.Zelenko wrote: > Missing link to guidelines, @

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-10 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. Have you run this check over any large code bases to see what its false positive rate looks like? I have to imagine we're going to need some escape hatch for system headers (we shouldn't complain about using declarations outside of the user's control).

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-07 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/abseil-alias-free-headers.rst:13 +The style guide http://google.github.io/styleguide/cppguide.html#Aliases discusses this +issue in more detail Missing link to guidelines, Repository:

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-07 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:73 + + Flags using declarations in header files, and suggests that + these aliases be removed Please highlight using with ``. Comment at: docs/clang-tidy/checks/abseil-al

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-07 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added inline comments. Comment at: clang-tidy/abseil/AliasFreeHeadersCheck.cpp:22 + // Match all using declarations in header files. + Finder->addMatcher(usingDecl(isExpansionInFileMatching(".*\\.h.*")).bind("x"), +this); Relevant: ``` $ clang-t

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-07 Thread Stephen Kelly via Phabricator via cfe-commits
steveire added a comment. Would it make sense to make this a generic non-abseil check? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55410/new/ https://reviews.llvm.org/D55410 ___ cfe-commits mailing li

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-07 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Please upload with full context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55410/new/ https://reviews.llvm.org/D55410 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D55410: [clang-tidy] check for flagging using declarations in headers

2018-12-06 Thread Shyan Akmal via Phabricator via cfe-commits
Naysh created this revision. Naysh added reviewers: EricWF, JonasToth. Herald added subscribers: cfe-commits, xazax.hun, mgorny. This patch adds an "Alias Free Headers" check, based off the guidelines at http://google.github.io/styleguide/cppguide.html#Aliases, to the abseil module. The purpose