This revision was automatically updated to reflect the committed changes.
Closed by commit rC349225: [analyzer] MoveChecker: NFC: De-duplicate a few
checks. (authored by dergachev, committed by ).
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55387/new/
https://re
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:265
+void MoveChecker::checkUse(ProgramStateRef State, const MemRegion *Region,
+ const CXXRecordDecl *RD, MisuseKind MK,
a_sidorin wrote:
> I think tha
NoQ updated this revision to Diff 178272.
NoQ marked 4 inline comments as done.
NoQ added a comment.
Fxd.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55387/new/
https://reviews.llvm.org/D55387
Files:
lib/StaticAnalyzer/Checkers/MoveChecker.cpp
Index: lib/StaticAnalyzer/Checkers/Mo
a_sidorin added a comment.
Hi Artem,
The overall idea is good but I have some remarks inline.
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:265
+void MoveChecker::checkUse(ProgramStateRef State, const MemRegion *Region,
+ const CXXRecordDec
NoQ updated this revision to Diff 177306.
NoQ marked 2 inline comments as done.
NoQ added a comment.
Fxd.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55387/new/
https://reviews.llvm.org/D55387
Files:
lib/StaticAnalyzer/Checkers/MoveChecker.cpp
Index: lib/StaticAnalyzer/Checkers/Mo
Szelethus accepted this revision.
Szelethus added a comment.
This revision is now accepted and ready to land.
Woohoo! Thanks!
Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:515-516
// class in which the encountered method defined.
while (const auto *BR = dyn_cast
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, george.karpenkov, szepet,
rnkovacs, Szelethus.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho,
a.sidorin, baloghadamsoftware.
NoQ added a parent revision: D55307: [analyzer] MoveChecker Pt
