[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

2018-12-06 Thread Stephen Kelly via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC348546: NFC: Move VisitExpr code to dumpStmt (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55339?vs=176870&id=177074#toc Repository: rC Clang CHANGES SINC

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

2018-12-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit. Comment at: lib/AST/ASTDumper.cpp:1698 +if (auto *E = dyn_cast(S)) { + NodeDumper.dumpType(E->getType()); --

[PATCH] D55339: NFC: Move VisitExpr code to dumpStmt

2018-12-05 Thread Stephen Kelly via Phabricator via cfe-commits
steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. The call is duplicated in the handlers of all Expr subclasses. This change makes it easy to split statement handling out to TextNodeDumper. Repository: rC Clang https://reviews.l