[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman closed this revision. aaron.ballman added a comment. Committed in r348400. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 ___ cfe-commits mai

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; steveire wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > Can

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

steveire added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; aaron.ballman wrote: > lebedev.ri wrote: > > Can you please also add one function with out-of-line definition? > Gladly! Is

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; lebedev.ri wrote: > Can you please also add one function with out-of-l

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman updated this revision to Diff 176807. aaron.ballman added a comment. Added a test with an out-of-line definition. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55321/new/ https://reviews.llvm.org/D55321 Files: lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp test/Sem

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

lebedev.ri added inline comments. Comment at: test/SemaCXX/warn-shadow.cpp:236 } + void F(int B); // Ok, declaration; not definition. }; Can you please also add one function with out-of-line definition? CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D55321: Do not check for parameters shadowing fields in function declarations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, george.karpenkov. Herald added subscribers: kristof.beyls, javed.absar. This patch changes the way we handle `-Wshadow-field` so that we do not issue diagnostics for parameters in function declarations (as those are harml