[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet added a comment. I agree. I'll have a look at it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added a comment. @courbet: On the cpplang Slack, Peter Feichtinger mentioned that defaulted template arguments should perhaps be treated differently. Is there any way to suppress the `, std::allocator` part of this diagnostic? https://godbolt.org/z/TM0UHc Before your patches: :1

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348741: [Sema] Further improvements to to static_assert diagnostics. (authored by courbet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet added a comment. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added a subscriber: saar.raz. Quuxplusone added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiatio

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiation

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1; // expected-note {{in instantiatio

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176773. courbet added a comment. - Update PHC and C11 tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp lib/Sema/S

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176771. courbet marked 2 inline comments as done. courbet added a comment. - Address comments - Add more tests - Remove AllowTopLevel and handle cases like `sizeof(T)` (-> `sizeof(int)`) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked 7 inline comments as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3065 + + ~FailedBooleanConditionPrinterHelper() override {} + Quuxplusone wrote: > aaron.ballman wrote: > > Is this definition necessary? > Nit: I don'

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

Quuxplusone added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3062 +public: + FailedBooleanConditionPrinterHelper(const PrintingPolicy &Policy) + : Policy(Policy) {} `explicit` Comment at: lib/Sema/SemaTemplate.cpp:3065 + + ~F

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3065 + + ~FailedBooleanConditionPrinterHelper() override {} + Is this definition necessary? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ htt

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. We're now handling cases like `static_assert(!expr)` and static_assert(!(expr))`. Repository: rC Clang https://reviews.llvm.org/D55270 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Ind