[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

This revision was automatically updated to reflect the committed changes. Closed by commit rC348387: [CodeComplete] Fix a crash in access checks of inner classes (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D55260?vs=176823&id=176847#toc Repository:

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 ___ c

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176823. ilya-biryukov added a comment. - Add a newline to the end of the test file Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 Files: lib/Sema/SemaAccess.cpp lib/Sema/Se

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. In D55260#1318280 , @kadircet wrote: > I believe also we need another test case where `Cls` and `NamingClass` are > different. Done. And thanks for finding this, I totally mi

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176821. ilya-biryukov added a comment. - Reformat Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 Files: lib/Sema/SemaAccess.cpp lib/Sema/SemaCodeComplete.cpp test/CodeCom

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176820. ilya-biryukov added a comment. - Make sure we still run ObjC access checks. - Add a test with a different NamingClass and BaseType. - Fix IsSimplyAccessible to work in this case. Repository: rC Clang CHANGES SINCE LAST ACTION https://revie

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet added a comment. I believe also we need another test case where `Cls` and `NamingClass` are different. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 ___ cfe-commit

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov updated this revision to Diff 176593. ilya-biryukov added a comment. - Actually use the computed NamingClass Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55260/new/ https://reviews.llvm.org/D55260 Files: lib/Sema/SemaCodeComplete.cpp test/Code

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

kadircet added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:1348 +} +return Results.getSema().IsSimplyAccessible(ND, Cls, BaseType); + } I suppose `Cls` should be `NamingClass` Repository: rC Clang CHANGES SINCE LAST ACTION https://r

[PATCH] D55260: [CodeComplete] Fix a crash in access checks of inner classes

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. The crash was introduced in r348135. Repository: rC Clang https://reviews.llvm.org/D55260 Files: lib/Sema/SemaCodeComplete.cpp test/CodeCompletion/accessibility.cpp Index: test/CodeCompletion/accessibility.c