This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE351792: [clangd] Support clang-tidy configuration in
clangd. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D55256?vs=182778&id=182862#toc
Repository:
rCTE C
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clangd/ClangdLSPServer.h:132
- RealFileSystemProvider FSProvider;
/// Options used for code completion
ilya-biryukov wrote:
> hokein wrote:
> > sammccall wrote:
> > > ilya-bi
ilya-biryukov added inline comments.
Comment at: clangd/ClangdLSPServer.h:132
- RealFileSystemProvider FSProvider;
/// Options used for code completion
hokein wrote:
> sammccall wrote:
> > ilya-biryukov wrote:
> > > Could we instead call `getRealFS()` when
hokein added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:438
+ auto OverrideClangTidyOptions = tidy::ClangTidyOptions::getDefaults();
+ if (!ClangTidyChecks.empty())
+OverrideClangTidyOptions.Checks = ClangTidyChecks;
sammccall wrote:
> This pre
hokein updated this revision to Diff 182778.
hokein marked 5 inline comments as done.
hokein added a comment.
Address comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55256/new/
https://reviews.llvm.org/D55256
Files:
clangd/ClangdLSPServer
sammccall accepted this revision.
sammccall added inline comments.
Comment at: clangd/tool/ClangdMain.cpp:204
+static llvm::cl::opt ClangTidyChecks(
+"clang-tidy-checks",
hokein wrote:
> sammccall wrote:
> > Maybe add a TODO or FIXME to respect .clang-tidy
hokein added inline comments.
Comment at: clangd/ClangdLSPServer.h:132
- RealFileSystemProvider FSProvider;
/// Options used for code completion
sammccall wrote:
> ilya-biryukov wrote:
> > Could we instead call `getRealFS()` when we try to initialize a clan
hokein updated this revision to Diff 182768.
hokein marked 7 inline comments as done.
hokein added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55256/new/
https://reviews.llvm.org/D55256
Files:
clangd/ClangdLS
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice! I think we should get to `.clang-tidy` files subsequently, but this is a
great start and allows us to hook up the right set of checks in other
environments.
Com
ilya-biryukov added a comment.
Just a small comment wrt to a particular change in `ClangdLSPServer`. I haven't
looked at the patch more closely, though.
Comment at: clangd/ClangdLSPServer.h:132
- RealFileSystemProvider FSProvider;
/// Options used for code completion
---
hokein added a comment.
I think this patch is ready for review now. ClangTidy configurations are
complicated, and we aim to support only a small subset of them (most are about
controlling which checks are going to run in clangd). I'd like to get some
initial feedbacks before making further chan
hokein updated this revision to Diff 181232.
hokein added a comment.
Rebase
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55256/new/
https://reviews.llvm.org/D55256
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServe
hokein updated this revision to Diff 176591.
hokein added a comment.
Minor cleanup
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55256/new/
https://reviews.llvm.org/D55256
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/Clan
hokein created this revision.
hokein added a reviewer: ilya-biryukov.
Herald added subscribers: kadircet, arphaman, jkorous, MaskRay, ioeric,
javed.absar.
Clangd will support a minimal set of clang-tidy configurations
- respect .clang-tidy for each file
- add a `clang-tidy-checks` CLI option tha
14 matches
Mail list logo
